Attention is currently required from: Michael Niewöhner, Kyösti Mälkki.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46075 )
Change subject: mb/aopen: Convert to ASL 2.0 syntax
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/aopen/dxplplusu/acpi/i82801db.asl:
https://review.coreboot.org/c/coreboot/+/46075/comment/b4a80947_ddedde21
PS5, Line 116: If (Local0 && 0x01)
Looks like original was wrong, bitwise and would make sense here. I'll rebase and push a fix.
yes please.
Thank you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib473121acfc0e985d4c0debecffdc1efbd9c3d66
Gerrit-Change-Number: 46075
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 07:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment