Hello Aaron Durbin, Patrick Rudolph, Subrata Banik, Angel Pons, Lean Sheng Tan, Teo Boon Tiong, Stefan Reinauer, Boon Tiong Teo, build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34166
to look at the new patch set (#3).
Change subject: soc/intel/{cnl,icl}: Drop open-source-abusive defaults for CAR
......................................................................
soc/intel/{cnl,icl}: Drop open-source-abusive defaults for CAR
The FSP_CAR option needs additional configuration, so it should never
be made the default without providing all other necessary defaults. It
seems rather offensive to guard sane defaults with a vendor selection,
so let's not add more guards to it and always make the working choice
the default instead.
Change-Id: I4a880f3093887628ce6bc9c39758e43688345713
Signed-off-by: Nico Huber nico.huber@secunet.com
---
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/icelake/Kconfig
2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/34166/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a880f3093887628ce6bc9c39758e43688345713
Gerrit-Change-Number: 34166
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: newpatchset