Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81589?usp=email )
Change subject: superio/ite: Add function to disable PME# output ......................................................................
superio/ite: Add function to disable PME# output
A function to disable the PME# output was added. This is required to set up the SuperIO on the "HP Pro 3500 Series" mb.
Change-Id: I94f023ba6eb24b5fb1c5e0b30eb65738f50a87eb Signed-off-by: Joel Linn jl@conductive.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/81589 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/superio/ite/common/early_serial.c M src/superio/ite/common/ite.h 2 files changed, 17 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Matt DeVillier: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/superio/ite/common/early_serial.c b/src/superio/ite/common/early_serial.c index b8a6ba5..ec218a6 100644 --- a/src/superio/ite/common/early_serial.c +++ b/src/superio/ite/common/early_serial.c @@ -15,6 +15,7 @@ #define ITE_CONFIG_REG_WATCHDOG 0x72 /* watchdog config */ #define ITE_CONFIG_REG_WDT_TIMEOUT_LSB 0x73 /* watchdog timeout (LSB) */ #define ITE_CONFIG_REG_WDT_TIMEOUT_MSB 0x74 /* watchdog timeout (MSB) */ +#define ITE_CONFIG_REG_APC_PME_CTL1 0xf2 /* APC_PME Control 1 */ #define ITE_CONFIG_REG_APC_PME_CTL2 0xf4 /* APC_PME Control 2 */
/* Helper procedure */ @@ -143,6 +144,21 @@ }
/* + * Disable PME# Output + * pass EC_DEV + */ +void ite_disable_pme_out(pnp_devfn_t dev) +{ + u8 tmp; + pnp_enter_conf_state(dev); + pnp_set_logical_device(dev); + tmp = pnp_read_config(dev, ITE_CONFIG_REG_APC_PME_CTL1); + tmp |= 0x40; + pnp_write_config(dev, ITE_CONFIG_REG_APC_PME_CTL1, tmp); + pnp_exit_conf_state(dev); +} + +/* * Set AC resume to be up to the Southbridge * pass EC_DEV */ diff --git a/src/superio/ite/common/ite.h b/src/superio/ite/common/ite.h index 1a147be..8a1ab58 100644 --- a/src/superio/ite/common/ite.h +++ b/src/superio/ite/common/ite.h @@ -18,6 +18,7 @@ void ite_set_3vsbsw(pnp_devfn_t dev, bool enable); void ite_delay_pwrgd3(pnp_devfn_t dev); void ite_kill_watchdog(pnp_devfn_t dev); +void ite_disable_pme_out(pnp_devfn_t dev); void ite_ac_resume_southbridge(pnp_devfn_t dev);
/* Alias for backwards compatibility */