Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46351 )
Change subject: soc/intel/broadwell/lpc.c: Drop reg-script usage for PCH misc init ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
I suppose this is for alignment, so the suggested improvements should happen later.
https://review.coreboot.org/c/coreboot/+/46351/4/src/soc/intel/broadwell/lpc... File src/soc/intel/broadwell/lpc.c:
https://review.coreboot.org/c/coreboot/+/46351/4/src/soc/intel/broadwell/lpc... PS4, Line 185: 1 I automatically stumbled here, would prefer `3 << 10`.
https://review.coreboot.org/c/coreboot/+/46351/4/src/soc/intel/broadwell/lpc... PS4, Line 186: reg16 |= (1 << 11); /* SLP_S3# Min Assertion Width 50ms */ and `2 << 10`
https://review.coreboot.org/c/coreboot/+/46351/4/src/soc/intel/broadwell/lpc... PS4, Line 229: reg8 |= 1 << 6; We trust now that it's 0 by default. I checked the ds, seems fine.