Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81662?usp=email )
(
8 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/intel/fsp2_0: Remove x64-specific assertion from fsp_header ......................................................................
drivers/intel/fsp2_0: Remove x64-specific assertion from fsp_header
Same fsp_header struture is being used for x64 and x32 modes and hence dropping the x64 assertion.
BUG=b:329034258 TEST=Verified on Meteor Lake board (Rex)
Change-Id: I6013af342670e6377a3fe7641d7d9b52c9b6f57c Signed-off-by: Appukuttan V K appukuttan.vk@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81662 Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Usha P usha.p@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/intel/fsp2_0/include/fsp/info_header.h 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified Usha P: Looks good to me, approved Subrata Banik: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/drivers/intel/fsp2_0/include/fsp/info_header.h b/src/drivers/intel/fsp2_0/include/fsp/info_header.h index f495822..a553436 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/info_header.h +++ b/src/drivers/intel/fsp2_0/include/fsp/info_header.h @@ -12,7 +12,6 @@ #define FSP_HDR_ATTRIB_FSPS 3 #define FSP_IMAGE_ID_LENGTH 8
-#if CONFIG(PLATFORM_USES_FSP2_X86_32) struct fsp_header { uint32_t signature; //FSPH uint32_t header_length; @@ -40,9 +39,6 @@ uint32_t fsp_multi_phase_mem_init_entry_offset; uint32_t res5; } __packed; -#else -#error You need to implement this struct for x86_64 FSP -#endif
enum cb_err fsp_identify(struct fsp_header *hdr, const void *fsp_blob);