Attention is currently required from: Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56009 )
Change subject: soc/intel/cannonlake: Switch PMC to use device callbacks
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/cannonlake/chip.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123175):
https://review.coreboot.org/c/coreboot/+/56009/comment/861c32b1_61e23ecf
PS2, Line 198: else if (dev->path.type == DEVICE_PATH_PCI &&
suspect code indent for conditional statements (8, 10)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If292728ad975ba803fed6abea879f6f634470a11
Gerrit-Change-Number: 56009
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 19:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment