Attention is currently required from: Patrick Rudolph.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46564 )
Change subject: mb/prodrive/hermes: Clean header files
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/prodrive/hermes/eeprom.c:
https://review.coreboot.org/c/coreboot/+/46564/comment/5b34813b_9189e6a9
PS4, Line 63: pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | I2C_EN);
Add this change (and removal of defines in .h file to comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79655a262d92a2e870d131ba7907bd0e94b98071
Gerrit-Change-Number: 46564
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 19 Jan 2021 13:51:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment