Attention is currently required from: Subrata Banik, Paul Menzel, Nick Vaccaro.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60271 )
Change subject: mb/google/brya: Add new baseboard nissa with variants nivviks and nereid
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60271/comment/00047fea_4880e57d
PS4, Line 10: Also
nit: Also,
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/60271/comment/338ea987_5262d069
PS4, Line 3: select SOC_INTEL_ALDERLAKE_PCH_P
@Reka: I have addressed this comment here CB:60378 […]
Thanks Subrata. Rebased on CB:60378 and CB:60379.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60271
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a3975fb7a45577fec8ea7c6c9f6ea042ab8cba5
Gerrit-Change-Number: 60271
Gerrit-PatchSet: 5
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Mon, 03 Jan 2022 23:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment