Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a VPD variable ......................................................................
Patch Set 8:
(2 comments)
Moved the implementation to x86/smbios.c, thanks for the suggestions, I'll just continue to finish the feature first. The VPD use in our plan for servers are not device-specific (for device-specific data is stored somewhere else called FRU) and normally the VPD should be erased and updated from version to version.
https://review.coreboot.org/c/coreboot/+/42029/2/src/drivers/vpd/smbios.c File src/drivers/vpd/smbios.c:
https://review.coreboot.org/c/coreboot/+/42029/2/src/drivers/vpd/smbios.c@5 PS2, Line 5: #include <smbios.h>
Do you mean sort the include files alphabetically? Just updated.
Done
https://review.coreboot.org/c/coreboot/+/42029/2/src/drivers/vpd/smbios.c@13 PS2, Line 13: smbios_mainboard_bios_version
This is meant as an override by the mainboard, you can't just use it here (e.g. […]
Moved to https://review.coreboot.org/c/coreboot/+/42029/8/src/arch/x86/smbios.c#376 The idea is trying to make it the default behavior by calling from the weak function, so we don't need to override the weak function for every board.