Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60993 )
Change subject: soc/intel/alderlake: Skip FSP to unlock GPIO Pads ......................................................................
soc/intel/alderlake: Skip FSP to unlock GPIO Pads
This patch makes FSP-S skip unlocking the GPIO Pads.
BUG=b:211573253, b:211950520 TEST=FSP-S debug log below:
Without this change: UnlockGpioPads= 1
With this changes UnlockGpioPads= 0
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I236a19a67372e9668e304d0054d477daff6a0266 Reviewed-on: https://review.coreboot.org/c/coreboot/+/60993 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index b18a70c..8284980 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -415,7 +415,7 @@ const bool lockdown_by_fsp = get_lockdown_config() == CHIPSET_LOCKDOWN_FSP; s_cfg->PchLockDownGlobalSmi = lockdown_by_fsp; s_cfg->PchLockDownBiosInterface = lockdown_by_fsp; - s_cfg->PchUnlockGpioPads = !lockdown_by_fsp; + s_cfg->PchUnlockGpioPads = lockdown_by_fsp; s_cfg->RtcMemoryLock = lockdown_by_fsp; s_cfg->SkipPamLock = !lockdown_by_fsp;