HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39821 )
Change subject: nb/i945: Split raminit into desktop and mobile version ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit_i945gc.c:
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... PS6, Line 450: by this chipset
Avoid changing this here, as it breaks BUILD_TIMELESS=1 verifiability.
Done
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... PS6, Line 285: i945
here is the file for 945gc. […]
Done
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... PS6, Line 873: if ((slew_group_lookup(dual_channel, idx * 8 + 2) != nc) &&
Can we split the cosmetic changes into a separate change?
Done