Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41011 )
Change subject: soc/intel/common: Add ASL for TCSS PCI segment
......................................................................
Patch Set 2:
Patch Set 1: Code-Review-1
(1 comment)
it should fail.
why it compile ??
we shouldn't have both of _ADR and _HID at the same time.
You are right that _ADR = PCI device typically where _HID = ACPI Soft device
But i have seen many instances where both exist together. didn't follow latest ACPI spec 6.3 if there is any hard rule to avoid that.
But noted your point and make the code changes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43924a3a34173ba3531079ef848f1935c59bb74a
Gerrit-Change-Number: 41011
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 03 May 2020 10:37:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment