Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33107 )
Change subject: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2 ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c@288 PS1, Line 288: if (find_fmap_directory(&fmrd) == 0)
While we're at it we should just use the hardcoded FMAP_OFFSET here (see below), no need to parse th […]
true, but I don't know the size. It's useful to mmap enough memory without parsing the fmap header first and to validate that the whole region falls within the mmap region as set by mmap_offset and mmap_size.
https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c@305 PS1, Line 305: size
sz
Done
https://review.coreboot.org/#/c/33107/1/src/lib/coreboot_table.c@307 PS1, Line 307: if (fmap_locate_area("COREBOOT", &ar)) {
These are hardcoded as __FMAP__COREBOOT_BASE and __FMAP__COREBOOT_SIZE, you don't need to look them […]
Done