View Change

3 comments:

• File src/lib/coreboot_table.c:

  • Patch Set #1, Line 288: if (find_fmap_directory(&fmrd) == 0)

    While we're at it we should just use the hardcoded FMAP_OFFSET here (see below), no need to parse th […]

    true, but I don't know the size.
    It's useful to mmap enough memory without parsing the fmap header first and to validate that the whole region falls within the mmap region as set by mmap_offset and mmap_size.

  • Patch Set #1, Line 305: size

    sz

    Done

  • Patch Set #1, Line 307: if (fmap_locate_area("COREBOOT", &ar)) {

    These are hardcoded as __FMAP__COREBOOT_BASE and __FMAP__COREBOOT_SIZE, you don't need to look them […]

    Done

To view, visit change 33107. To unsubscribe, or for help writing mail filters, visit settings.