[coreboot-gerrit] [L] Change in coreboot[main]: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1)

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change by Federico Amedeo Izzo. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )

Change subject: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1)
......................................................................

Patch Set 17:

(1 comment)

Patchset:

PS17:
> You both were right, disabling `CONFIG_CONSOLE_SERIAL` reduced the boot time to 1. […]

Thank you again for the logs and responding.

Memory training (without MRC cache or booting the first time with empty cache) takes the expected time (around 30 seconds):

aoostar/wtr_r1/24.05-388-g1f5a221a51/2024-06-29T22_51_16Z/coreboot_timestamps.txt
    […]
    950:calling FspMemoryInit                             168,130 (108,717)
    951:returning from FspMemoryInit                      31,738,002 (31,569,872)
    […]
     90:starting to load payload                          32,460,379 (392)
     15:starting LZMA decompress (ignore for x86)         32,460,440 (60)
     16:finished LZMA decompress (ignore for x86)         33,443,057 (982,617)

The long decompression time (above and below) is surprising to me though:

aoostar/wtr_r1/24.05-173-gbf1166e8a6/2024-06-07T06_16_41Z/coreboot_timestamps.txt
    […]
    962:calling FspMultiPhaseSiInit                       634,246 (0)
    963:returning from FspMultiPhaseSiInit                1,108,438 (474,192)
    […]
     90:starting to load payload                          1,127,814 (363)
     15:starting LZMA decompress (ignore for x86)         1,127,875 (60)
     16:finished LZMA decompress (ignore for x86)         2,099,501 (971,625)

The payload is 1.3 MB in size and despite cbfstool claiming it’s not compressed, the config says it is (`CONFIG_COMPRESSED_PAYLOAD_LZMA=y`).

fallback/payload               0x1647c0   simple elf    1288296 none