Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48811 )
Change subject: fmaptool: Add option to dump fmap ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48811/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48811/2//COMMIT_MSG@10 PS2, Line 10: coreboot does not include a utility : that lets you read the fmap from an image
Hm.. ok I missed that. I suggest to drop this functionality from futility. […]
I mean... we won't drop this from futility, it's been there for ages and we use it all the time. Not sure what you mean by small subset of machines? futility should run everywhere other coreboot build utilities run, there's no fundamental difference there... of course we don't have continuous integration for anything other than x86 Linux, but that's a problem with the coreboot infra, not specific to futility. If you find that futility doesn't build or work on a specific platform, we're happy to take fixes (e.g. Idwer submitted some to make it run on FreeBSD recently).
If you really want to have this somewhere else I don't mind, especially since it's just a small call to an existing library. It just seems like unnecessary duplication to me. Especially since the futility version looks much better (dump_fmap -h gives you a nice indented view of nested sections, this just prints them all very raw and so verbose it fills multiple screens). And also because this is just an intermediate build tool that's not really getting installed or used independently anywhere. If you want this functionality somewhere else, I think putting it into cbfstool would make more sense (it's pretty much an FMAP manipulator with cbfstool read / cbfstool write already anyway).