Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46665 )
Change subject: sb/intel/lynxpoint: Ensure that `dev->chip_info` is not null ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... PS2, Line 144: config_t *config = config_of(dev);
Since this is only called from a single place, I can eliminate the check from here completely and re […]
Ack
I wonder how I could miss it, isn't everything called from lpc_init() with the same `dev` pointer?
https://review.coreboot.org/c/coreboot/+/46665/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/serialio.c:
https://review.coreboot.org/c/coreboot/+/46665/3/src/southbridge/intel/lynxp... PS3, Line 134: struct southbridge_intel_lynxpoint_config *config = config_of(dev); Or bail out if it's NULL?