[coreboot-gerrit] Change in ...coreboot[master]: intel/spi: Define PCI accessor aliases only once

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31270 )

Change subject: intel/spi: Define PCI accessor aliases only once
......................................................................

Patch Set 4:
> > If this comes from flashrom it must have been long
> > ago. flashrom uses libpci. Why not just use coreboot
> > functions proper? (or integrate libflashrom :p)
> >
> > In any case, I don't think it makes sense to mention
> > flashrom in the source. And ofc, it might be a good
> > idea to consolidate the copies so the next cleanup
> > doesn't have to do the same changes 6 times again.
>
> Well consolidating the copies is not the scope here, the files have drifted too much to make them one. So would using coreboot proper functions score +2 here?

Yes, I guess. It just seems weird to call things
flashrom-compat if that is already obsolete infor-
mation. So anything that gets rid of that notion
would already silence my concerns.