Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46855 )
Change subject: mrc_cache: Move force memory retraining code into mrc_cache ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46855/1/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46855/1/src/drivers/mrc_cache/mrc_c... PS1, Line 264: if (!CONFIG(HAS_RECOVERY_MRC_CACHE))
I don't think we can add this here unless we want to change policy. […]
Ok, I added the CONFIG_MRC_ALWAYS_RETRAIN_IN_RECOVERY config and it seems to work just fine with just that config. I think that I got all the test cases in TEST=.
I'm not sure what you mean by making the Kconfig "decide whether normal_training has RECOVERY_FLAG set or not"? Can you please elaborate?