27 May
2020
27 May
'20
3:15 p.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41639 )
Change subject: ec/google/chromeec/acpi/superio: Add PS/2 Mouse ACPI entry ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41639/2/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/41639/2/src/ec/google/chromeec/acpi... PS2, Line 167: Name (_HID, "GOOG0015") Why is a separate HID needed?
https://review.coreboot.org/c/coreboot/+/41639/2/src/ec/google/chromeec/acpi... PS2, Line 185: } Why can’t `src/drivers/pc80/pc/ps2_controller.asl` be reused?
--
To view, visit https://review.coreboot.org/c/coreboot/+/41639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a4f071ad54730ea75f75ebf1633a4a08f7f2dd0
Gerrit-Change-Number: 41639
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 18:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment