Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown ......................................................................
Patch Set 11:
(4 comments)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70773/comment/2058e2f1_b1706eb8 PS11, Line 16: #include <ec/google/chromeec/ec.h> nit: consider alphabetic order please
https://review.coreboot.org/c/coreboot/+/70773/comment/99a85533_75a29c00 PS11, Line 217: __weak i don't think you need the `weak` implementation anymore now.
https://review.coreboot.org/c/coreboot/+/70773/comment/0507cddf_5abd53b8 PS11, Line 219: if (CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) { suggestion:
``` if (!CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) return;
/* Send EC command to clear AP_IDLE flag */ if (!google_chromeec_reboot(0, EC_REBOOT_NO_OP, EC_REBOOT_FLAG_CLEAR_AP_IDLE | EC_REBOOT_FLAG_ON_AP_SHUTDOWN)) printk(BIOS_INFO, "Successfully clear AP_IDLE flag"); else printk(BIOS_ERR, "Failed to clear EC AP_IDLE flag"); ```
File src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/70773/comment/17008e46_dd5a0aa5 PS11, Line 28: variant_prepare_cr50_reset mainboard_prepare_cr50_reset