Attention is currently required from: Alicja Michalska.
Name of user not set #1004406 has posted comments on this change by Name of user not set #1004406. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email )
Change subject: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake) ......................................................................
Patch Set 20:
(3 comments)
File src/mainboard/asrock/h370m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/65225/comment/eb7f2b35_50e2f5b2?usp... : PS20, Line 6: register "s0ix_enable" = "1"
Try disabling it, platform might suspend correctly if you use S3 state instead
you are right. removing s0ix_enable and setting PchPmSlpS3* result in a correct sleep down. but the system doesnt wake up correctly. keyboard doesnt trigger wakeup and power button will result in a broken state.
https://review.coreboot.org/c/coreboot/+/65225/comment/c7370f34_22f3d1f3?usp... : PS20, Line 14: device ref igpu on end
Did you forget to include DDI configuration? […]
i have no igpu. is this still possible?
https://review.coreboot.org/c/coreboot/+/65225/comment/ff600920_b47edeb4?usp... : PS20, Line 115: device ref lpc_espi on
You can obtain a copy of datasheet for SuperIO from Nuvoton if you send them an email. […]
thanks for that information. i will contact nuvoton.
a NCT5567D-B is used here but it seems that the ID is identical to the NCT5539D.