Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39530 )
Change subject: soc/intel/Kconfig: Avoid specify dedicated chipset name
......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
I had attempted this in past, had a review comment (below) on why order in required:
"
Order might matter here, that `common/Kconfig` is sourced last
is likely intentional.
Usually this is done so that the common code can provide a default
and SoCs can override it (first `default` line encountered by
Kconfig takes precedence)."
Correct. I think we can potentially do this:
Rename: src/soc/intel/common/Kconfig to src/soc/intel/common/Kconfig.common
Change: All specific SoC sources to "source src/soc/intel/*/Kconfig"
Change: Common source to "source src/soc/intel/common/Kconfig.common"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2d8a8ac1c4acfabd4ded1bfd4ff359e820e174b
Gerrit-Change-Number: 39530
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 08:37:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment