Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39742 )
Change subject: mb/gigabyte/ga-h61m-s2pv: Correct PCIe port setup
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39742/2/src/mainboard/gigabyte/ga-h...
File src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39742/2/src/mainboard/gigabyte/ga-h...
PS2, Line 50: device pci 1c.1 off end # RP #2:
It actually is unused, though? This board, unlike the other two variants, only has one PCIe x1 slot.
Any updates?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f4bf99ceec6c77f6e1eabea9b712245afee7d34
Gerrit-Change-Number: 39742
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Mar 2020 09:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment