EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36512 )
Change subject: mb/g/drallion: Override smbios enclosure type for drallion
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36512/3/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/smbios.c:
https://review.coreboot.org/c/coreboot/+/36512/3/src/mainboard/google/dralli...
PS3, Line 22: if (gpio_get(SENSOR_DET_360) == 0)
how about return gpio_get(SENSOR_DET_360) :SMBIOS_ENCLOSURE_LAPTOP ?SMBIOS_ENCLOSURE_CONVERTIBLE
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I766e9a4b22a490bc8252670a06504437e82f72d5
Gerrit-Change-Number: 36512
Gerrit-PatchSet: 3
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Oct 2019 19:05:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment