Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208 ......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11: Hi, When adding a new hardware component that requires a bit in the FW_CONFIG field, please do not just replace an existing entry with a new one. Hard-coded replacement like is implemented in this CL breaks all support for the hardware component being replaced. In this case, it broke support for the older OV5675 cameras that are still in use on older brya hardware.
Here's an example of how to add a new hardware component, in this case, a new UFC model. This CL does a little more than just add the new UFC module, but can be used to see how to change FW_CONFIG and how to use the probe macro to query for camera type and only enable the device associated with that particular camera model (I'll add you as a reviewer):
https://review.coreboot.org/c/coreboot/+/67929/2/src/mainboard/google/brya/v...
Thanks much.