[coreboot-gerrit] Change in coreboot[master]: [RFC] soc/intel/skylake: Introduce new method for setting device states

[Felix Singer (Code Review)]

Attention is currently required from: Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Michael Niewöhner, Patrick Rudolph, Felix Held.
 Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )

Change subject: [RFC] soc/intel/skylake: Introduce new method for setting device states
......................................................................

Patch Set 12:

(4 comments)

File src/soc/intel/skylake/fspdevmap.h:

https://review.coreboot.org/c/coreboot/+/52493/comment/5ebd0b2f_9072bff7 
PS9, Line 13: uint8_t
> `unsigned int` or `size_t` please. There is no reason to constrain the API.

Done

https://review.coreboot.org/c/coreboot/+/52493/comment/0a83f8ae_97921256 
PS9, Line 13: const
> Got it, thanks for explaining :)

Done

File src/soc/intel/skylake/fspdevmap.c:

https://review.coreboot.org/c/coreboot/+/52493/comment/b7d72a59_4ab7977b 
PS9, Line 9: uint8_t
> `unsigned int` or maybe `size_t` please.

Done

https://review.coreboot.org/c/coreboot/+/52493/comment/5eb59a17_a3f00051 
PS9, Line 13: 		if (dev) {
> heh, I love it!

Done