Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48622 )
Change subject: WIP: soc/mediatek/mt8192: add apusys init flow ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/48622/5/src/soc/mediatek/mt8192/apu... File src/soc/mediatek/mt8192/apusys.c:
https://review.coreboot.org/c/coreboot/+/48622/5/src/soc/mediatek/mt8192/apu... PS5, Line 24: (u8 *) no need to cast here if you will do (void *) later.
https://review.coreboot.org/c/coreboot/+/48622/5/src/soc/mediatek/mt8192/apu... PS5, Line 24: 0x100 add a comment for name of the regsiter in MBOX + i*0x100 + 0xb0
https://review.coreboot.org/c/coreboot/+/48622/5/src/soc/mediatek/mt8192/apu... PS5, Line 26: SET32_BITFIELDS(addr, : NO_MPU, 1, LOCK, 1); this can be in one line.
https://review.coreboot.org/c/coreboot/+/48622/5/src/soc/mediatek/mt8192/apu... PS5, Line 29: 0x%x %#x
https://review.coreboot.org/c/coreboot/+/48622/5/src/soc/mediatek/mt8192/apu... PS5, Line 29: 0x%x %p (do we support that in coreboot?) or %#x
https://review.coreboot.org/c/coreboot/+/48622/5/src/soc/mediatek/mt8192/apu... PS5, Line 30: APUSYS_MBOX + i * 0x100 + 0xb0 (uintptr_t)addr