build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47988 )
Change subject: soc/intel/common/dmi: Add DMI driver support ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47988/6/src/soc/intel/common/block/... File src/soc/intel/common/block/dmi/dmi.c:
https://review.coreboot.org/c/coreboot/+/47988/6/src/soc/intel/common/block/... PS6, Line 10: #define GPMR_OFFSET(x) (0x277c + (x)* 8) need consistent spacing around '*' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47988/6/src/soc/intel/common/block/... PS6, Line 15: #define GPMR_DID_OFFSET(x) (0x2780 + (x)* 8) need consistent spacing around '*' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47988/6/src/soc/intel/common/block/... PS6, Line 58: if (limit < base){ space required before the open brace '{'