Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51668 )
Change subject: soc/amd/common/block/psp/psp: update psp_status_nobase error message ......................................................................
soc/amd/common/block/psp/psp: update psp_status_nobase error message
When the soc_get_mbox_address functions returns 0 after not being able to find an initialized PSP base address MSR or in case of Stoneyridge the PSP's BAR3, the code will print an error string. This string needs to reference both PSP_ADDR_MSR and PSP BAR3 and not only the latter one, since in Picasso and Cezanne only the former one is present.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I32a1e87e2a7d89c7b53f47c987e7bf0556154cf7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/51668 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/soc/amd/common/block/psp/psp.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/psp/psp.c b/src/soc/amd/common/block/psp/psp.c index 45d64d8..b955459 100644 --- a/src/soc/amd/common/block/psp/psp.c +++ b/src/soc/amd/common/block/psp/psp.c @@ -7,7 +7,7 @@ #include <soc/iomap.h> #include "psp_def.h"
-static const char *psp_status_nobase = "error: PSP BAR3 not assigned"; +static const char *psp_status_nobase = "error: PSP_ADDR_MSR and PSP BAR3 not assigned"; static const char *psp_status_halted = "error: PSP in halted state"; static const char *psp_status_recovery = "error: PSP recovery required"; static const char *psp_status_errcmd = "error sending command";