Attention is currently required from: Martin Roth. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50240 )
Change subject: soc/amd/picasso: add UPD for USB3 phy setting adjust ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50240/comment/247d5254_a8cbb92d PS4, Line 7: adjsut
*adjust*
Done
https://review.coreboot.org/c/coreboot/+/50240/comment/3d2578d5_88e118ec PS4, Line 12: 1. RX_EQ_DELTA_IQ_OVRD_VAL- Override value for rx_eq_delta_iq. Range 0-0xF : 2. RX_EQ_DELTA_IQ_OVRD_EN - Enable override value for rx_eq_delta_iq. Range 0-0x1
Nit: Split these to 2 lines each?
Done
File src/soc/amd/picasso/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50240/comment/c04f18c7_a5047a96 PS4, Line 130: cfg->usb3_phy_en
Don't you want to copy this too? It's in the UPD.
Yes, I missed this one.
https://review.coreboot.org/c/coreboot/+/50240/comment/921250da_22f9ce6d PS4, Line 131: memcpy(&scfg->usb_3_port0_phy_tune, &cfg->usb3_phy_tune_params[0], : sizeof(scfg->usb_3_port0_phy_tune[0]));
Is there a case where we might want to set the values for only one port or is it required that all 4 […]
For the RX_EQ_DELTA_IQ_OVRD_VAL and RX_EQ_DELTA_IQ_OVRD_EN. it should able to set the values by port. but others will apply to all. The usb3_phy_en is a switch to enable the usb3 phy setting override.