Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45410 )
Change subject: mb/ocp/deltalake: Insert IO port in linux command line ......................................................................
Patch Set 2:
(4 comments)
I’d do this unconditionally, when VPD is selected.
https://review.coreboot.org/c/coreboot/+/45410/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45410/2//COMMIT_MSG@12 PS2, Line 12: use uses
https://review.coreboot.org/c/coreboot/+/45410/2//COMMIT_MSG@12 PS2, Line 12: payload Linux payload?
https://review.coreboot.org/c/coreboot/+/45410/2/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/45410/2/src/mainboard/ocp/deltalake... PS2, Line 57: config LINUX_COMMAND_LINE_OVERRIDE The name needs to be namespaced. I’d prefer it in the Linux payload section though.
https://review.coreboot.org/c/coreboot/+/45410/2/src/mainboard/ocp/deltalake... PS2, Line 61: Override linux command line by using VPD. Please elaborate.