[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake: Add GLK usb2eye configuration override

[Seunghwan Kim (Code Review)]

Seunghwan Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31060 )

Change subject: soc/intel/apollolake: Add GLK usb2eye configuration override
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c@554 
PS2, Line 554: if (!cfg->usb2eye[port].Usb20OverrideEn)
             : 			continue;
> Is the default value of this UPD non-zero? If not, then it doesn't matter. […]

https://chrome-internal.googlesource.com/chromeos/third_party/intel-fsp/glk/...

Usb2AfePetxiset and Usb2AfePredeemp have non zero default values.

# !BSF NAME:{USB Per Port HS Preemphasis Bias} TYPE:{EditNum, HEX, (0x00,0xFFFFFFFFFFFFFFFF)}
  # !BSF HELP:{USB Per Port HS Preemphasis Bias. 000b-0mV, 001b-40.5mV, 010b-60.5mV, 011b-102mV, 100b-102mV, 101b-142mV, 110b-162.5mV, 111b-202.5mV. One byte for each port.}
  gGlkFspPkgTokenSpaceGuid.Usb2AfePetxiset                      | 0x0388 | 0x8 | {0x01, 0x05, 0x05, 0x05, 0x05, 0x05, 0x05, 0x05}
  # !BSF NAME:{USB Per Port HS Transmitter Bias} TYPE:{EditNum, HEX, (0x00,0x0xFFFFFFFFFFFFFFFF)}
  # !BSF HELP:{USB Per Port HS Transmitter Bias. 000b-0mV, 001b-40.5mV, 010b-60.5mV, 011b-102mV, 100b-102mV, 101b-142mV, 110b-162.5mV, 111b-202.5mV. One byte for each port.}
  gGlkFspPkgTokenSpaceGuid.Usb2AfeTxiset                        | 0x0390 | 0x8 | {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}
  # !BSF NAME:{USB Per Port HS Transmitter Emphasis} TYPE:{EditNum, HEX, (0x00,0x0xFFFFFFFFFFFFFFFF)}
  # !BSF HELP:{USB Per Port HS Transmitter Emphasis. 00b - Emphasis OFF, 01b - De-emphasis ON, 10b - Pre-emphasis ON, 11b - Pre-emphasis & De-emphasis ON. One byte for each port.}
  gGlkFspPkgTokenSpaceGuid.Usb2AfePredeemp                      | 0x0398 | 0x8 | {0x03, 0x03, 0x03, 0x03, 0x03, 0x03, 0x03, 0x03}
  # !BSF NAME:{USB Per Port Half Bit Pre-emphasis} TYPE:{EditNum, HEX, (0x00,0x0xFFFFFFFFFFFFFFFF)}
  # !BSF HELP:{USB Per Port Half Bit Pre-emphasis. 1b - half-bit pre-emphasis, 0b - full-bit pre-emphasis. One byte for each port.}
  gGlkFspPkgTokenSpaceGuid.Usb2AfePehalfbit                     | 0x03A0 | 0x8 | {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}