Attention is currently required from: Stefan Reinauer, Paul Menzel.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40811 )
Change subject: arch,toolchain,xcompile: Use GCC as linker
......................................................................
Patch Set 7:
(2 comments)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40811/comment/d3eb6a3f_efe7abbe
PS6, Line 488: --emit-relocs,
This was split out in I784a506034325c0ba937589416acaafbf80080e2.
Ack
File toolchain.inc:
https://review.coreboot.org/c/coreboot/+/40811/comment/cf7f007d_6be191bd
PS6, Line 107: LD_$(1) := $(CC_$(2))
It might be cleaner to use CC_.. at the target sites.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40811
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia551cf84c8f6eb3b010450fc572876a318a257d1
Gerrit-Change-Number: 40811
Gerrit-PatchSet: 7
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 23 May 2021 19:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment