Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39821 )
Change subject: nb/i945: Split ramint into desktop and mobile version ......................................................................
Patch Set 6:
(4 comments)
It would be nice if this could be split up a bit. The idea is that cosmetic changes should result in a reprodible coreboot.rom (identical before and after applying this change) when using BUILD_TIMELESS=1
If the binary does not change, it's not going to break anything 😄
https://review.coreboot.org/c/coreboot/+/39821/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39821/6//COMMIT_MSG@7 PS6, Line 7: ramint raminit
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit_i945gc.c:
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... PS6, Line 450: by this chipset Avoid changing this here, as it breaks BUILD_TIMELESS=1 verifiability.
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... PS6, Line 285: i945 not all i945 though
https://review.coreboot.org/c/coreboot/+/39821/6/src/northbridge/intel/i945/... PS6, Line 873: if ((slew_group_lookup(dual_channel, idx * 8 + 2) != nc) && Can we split the cosmetic changes into a separate change?