Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5446
-gerrit
commit d74b6b4803a1c95cef2476722fb6203571abf034 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Thu Apr 3 03:19:41 2014 +1100
superio/nuvoton/nct5104d: Avoid .c includes
Following the same reasoning as commit d304331 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code.
Change-Id: I14c438968bfed917977862efd8a393ec48cb04c9 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/superio/nuvoton/nct5104d/Makefile.inc | 1 - src/superio/nuvoton/nct5104d/early_init.c | 5 ++--- src/superio/nuvoton/nct5104d/nct5104d.h | 4 +++- 3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/superio/nuvoton/nct5104d/Makefile.inc b/src/superio/nuvoton/nct5104d/Makefile.inc index b9345aa..7c97d05 100644 --- a/src/superio/nuvoton/nct5104d/Makefile.inc +++ b/src/superio/nuvoton/nct5104d/Makefile.inc @@ -20,4 +20,3 @@
romstage-$(CONFIG_SUPERIO_NUVOTON_NCT5104D) += early_init.c ramstage-$(CONFIG_SUPERIO_NUVOTON_NCT5104D) += superio.c - diff --git a/src/superio/nuvoton/nct5104d/early_init.c b/src/superio/nuvoton/nct5104d/early_init.c index 9c0cf0f..f3d8990 100644 --- a/src/superio/nuvoton/nct5104d/early_init.c +++ b/src/superio/nuvoton/nct5104d/early_init.c @@ -19,8 +19,7 @@ */
#include <arch/io.h> -#include <arch/romcc_io.h> -#include <device/pnp_def.h> +#include <device/pnp.h> #include "nct5104d.h"
static void pnp_enter_extended_mode(device_t dev) @@ -36,7 +35,7 @@ static void pnp_exit_extended_mode(device_t dev) outb(0xaa,port); }
-static void nct5104d_enable_serial(device_t dev, u16 iobase) +void nct5104d_enable_serial(device_t dev, u16 iobase) { pnp_enter_extended_mode(dev); pnp_set_logical_device(dev); diff --git a/src/superio/nuvoton/nct5104d/nct5104d.h b/src/superio/nuvoton/nct5104d/nct5104d.h index 2f833af..98baf81 100644 --- a/src/superio/nuvoton/nct5104d/nct5104d.h +++ b/src/superio/nuvoton/nct5104d/nct5104d.h @@ -37,4 +37,6 @@ #define NCT5104D_GPIO1 ((1 << 8) | NCT5104D_GPIO_V) #define NCT5104D_GPIO6 ((6 << 8) | NCT5104D_GPIO_V)
-#endif +void nct5104d_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_NUVOTON_NCT5104D_NCT5104D_H */