Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38542 )
Change subject: sc7180: QSIP SPI NOR addressing mode ......................................................................
Patch Set 4:
Is this just a temporary patch you want to carry locally to enable your development board? If so, please prefix the subject with HACK: so people know that you're not intending it for merge and it doesn't need to be reviewed.
If you do want to merge this permanently, we can do that too but like Aaron said it needs to be done cleaner than this (would probably want to actually implement 4-byte address support then, rather than just disable it and have half the flash inaccessible). But considering that we're not planning to officially add your development board to coreboot and Trogdor isn't using this chip, I don't think we'll need to go there?