9 Dec
2019
9 Dec
'19
4:48 p.m.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37552 )
Change subject: amdblocks/pci: add common implementation of MMCONF enabling ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37552/2/src/soc/amd/common/block/pc... File src/soc/amd/common/block/pci/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37552/2/src/soc/amd/common/block/pc... PS2, Line 6: ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_PCI_MMCONF) += amd_pci_mmconf.c
IMHO we do not need the guard, it is still behind SOC_AMD_COMMON : […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/37552
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bb8b22b282584c421a9fffa3322b2a8e406d037
Gerrit-Change-Number: 37552
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 16:48:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment