Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42114 )
Change subject: spi/winbond: Pull out winbond_get_bpbits function ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42114/2/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/c/coreboot/+/42114/2/src/drivers/spi/winbond.c@2... PS2, Line 211: static int winbond_get_bpbits(const struct spi_flash *flash, Please don't forward declare static functions, just reorder the functions until that's unnecessary (i.e. move winbond_get_bpbits() above winbond_get_write_protection()).