Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36519 )
Change subject: soc/intel/cannonlake: Disable USB2 PHY Power gating
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36519/12/src/soc/intel/cannonlake/c...
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/36519/12/src/soc/intel/cannonlake/c...
PS12, Line 134: PchUsb2PhySusPgEnable
It's a good suggestion. […]
It looks like the FSP variable defaults to 1 though, which is something we can't do here. If someone looked at the FSP BSF and saw it says default 1 they might not set it in coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95909c73de758fccc7f616a330c1e1f0667e8c25
Gerrit-Change-Number: 36519
Gerrit-PatchSet: 12
Gerrit-Owner: Surendranath R Gurivireddy
surendranath.r.gurivireddy@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Surendranath R Gurivireddy
surendranath.r.gurivireddy@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Nov 2019 23:56:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Surendranath R Gurivireddy
surendranath.r.gurivireddy@intel.com
Gerrit-MessageType: comment