Evan Green has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43153 )
Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................
mb/google/dedede: Add Goodix touchscreen
Add overridetree info for the touchscreen, and make a define for TOUCH_INT_ODL since everyone else seems to do that.
BUG=b:160129126 TEST=cros flash-ap -b dedede
Signed-off-by: Evan Green evgreen@chromium.org Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 --- M src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h M src/mainboard/google/dedede/variants/waddledee/overridetree.cb 2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43153/1
diff --git a/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h b/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h index c7e4605..dabefeb 100644 --- a/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h +++ b/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h @@ -9,4 +9,6 @@
#include <baseboard/gpio.h>
+#define TOUCH_INT_ODL GPP_D4_IRQ + #endif /* MAINBOARD_GPIO_H */ diff --git a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb index 33c578c..6223165 100644 --- a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb @@ -66,5 +66,22 @@ device i2c 0x2c on end end end + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 14 on end # TODO: Someone plz scan to see what the right value is here. + end + end end end