Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4
......................................................................
Patch Set 6:
IMHO, the best solution would be to patch pci_set_resource()
to always process bridge resources if their size is 0. If it
is not 0, or it's a non-bridge resource, check the assigned
status. iow.
if ((!(resource->flags & IORESOURCE_BRIDGE) || resource->size > 0)
&& !(resource->flags & IORESOURCE_ASSIGNED)) {
complain;
return;
}
Probably even better would be to always treat unassigned bridge
resources as if their size was 0. This would leave only a single
assumption about the allocator: If a resource is marked as
assigned, it is properly allocated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide4d98528197bb03850a8fb4d73c41cd2c0195aa
Gerrit-Change-Number: 41443
Gerrit-PatchSet: 6
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 May 2020 22:11:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment