9 Dec
2020
9 Dec
'20
12:06 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48201 )
Change subject: Makefile.inc: Fix empty output when processing C struct files in CBFS ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc@336 PS5, Line 336:
$$(<) \n […]
Can't say that I follow.
I would not block the change over this, but be warned: people write patches just to remove such unneeded whitespace. So it might not last.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48201
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6a66e25d7dfe8fe6410e517593ed22a438d2f82
Gerrit-Change-Number: 48201
Gerrit-PatchSet: 5
Gerrit-Owner: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Dec 2020 23:06:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xi Chen xixi.chen@mediatek.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment