Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80253?usp=email )
Change subject: libpayload: Switch to commonlib ipchksum() algorithm ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: FILO fails to build now, I believe:
``` CC build/main/elfload.o In file included from /dev/shm/coreboot/payloads/external/FILO/filo/main/elfload.c:32: include/ipchecksum.h:21:16: error: conflicting types for 'ipchksum'; have 'short unsigned int(const void *, long unsigned int)' 21 | unsigned short ipchksum(const void *data, unsigned long length); | ^~~~~~~~ In file included from /dev/shm/coreboot/payloads/external/FILO/filo/build/libpayload/bin/../include/libpayload.h:51, from /dev/shm/coreboot/payloads/external/FILO/filo/main/elfload.c:24: /dev/shm/coreboot/payloads/external/FILO/filo/build/libpayload/bin/../include/commonlib/bsd/ipchksum.h:9:10: note: previous declaration of 'ipchksum' with type 'uint16_t(const void *, size_t)' {aka 'short unsigned int(const void *, unsigned int)'} 9 | uint16_t ipchksum(const void *data, size_t size); | ^~~~~~~~ make[2]: *** [Makefile.standalone:35: /dev/shm/coreboot/payloads/external/FILO/filo/build/main/elfload.o] Error 1 ```