Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40403 )
Change subject: mb/up/squared: Fix eMMC speed for UP2 with EDK2 ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40403/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40403/4//COMMIT_MSG@9 PS4, Line 9: Historically the UP2's eMMC maximum host speed was reduced to : DDR50, because HS200 showed I/O errors in the host kernel.
Please add a reference.
Ack
https://review.coreboot.org/c/coreboot/+/40403/4//COMMIT_MSG@13 PS4, Line 13: Therefore eMMC would not show up for boot device selection.
Please re-flow for 72/75 characters.
Ack
https://review.coreboot.org/c/coreboot/+/40403/4//COMMIT_MSG@17 PS4, Line 17: ramstage.c to the devicetree.cb file for better maintainability.
The setting seems to be already present in the devicetree.
I don't see that. Could you please tell me why you think that?
I did git diff against master and couldn't find a eMMC host speed setting there.
https://review.coreboot.org/c/coreboot/+/40403/4/payloads/external/tianocore... File payloads/external/tianocore/Makefile:
PS4:
This seems unrelated. Please separate it into a separate commit.
Ack