Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45174 )
Change subject: nb/intel/ironlake/raminit: Fix compiler bug ......................................................................
nb/intel/ironlake/raminit: Fix compiler bug
This fixes e1d1fe454cf27d6b1c2ef5625f1cefc1a9c6ec9d initialize 'reply.command'.
The compiler now optimized away the final condition, resulting in a binary that always calls die().
Fix that behaviour by using volatile. Tested on Lenovo T410: Boots again into Linux.
Change-Id: I63cffc8812bd22695c01bf57283ca593b12e3d87 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/ironlake/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/45174/1
diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c index 81ba450..5d58b27 100644 --- a/src/northbridge/intel/ironlake/raminit.c +++ b/src/northbridge/intel/ironlake/raminit.c @@ -1770,7 +1770,7 @@
static void send_heci_uma_message(struct raminfo *info) { - struct uma_reply { + volatile struct uma_reply { u8 group_id; u8 command; u8 reserved;