[coreboot-gerrit] Change in coreboot[master]: Revert "soc/intel/common/{pch,sata}: Remove SATA common code driver"

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43077 )

Change subject: Revert "soc/intel/common/{pch,sata}: Remove SATA common code driver"
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4: Code-Review-1
> >
> > This code was removed because it's wrong. The register definitions changed between SPT and CNP. If only Comet Lake is having problems, I'd suggest having a Comet Lake-specific driver.
>
> I think the problem is with FSP not enabling bus master as outlined here: https://review.coreboot.org/c/coreboot/+/21890/. With this driver being removed we might have regressed SKL and KBL boards using SATA. At minimum, we should add support back for setting the Bus Master for AHCI.

Agree Furquan, let me try something i have one board connected and share a CL with Andrew tomorrow