Attention is currently required from: Kangheui Won, Chen Wisley, Tim Wawrzynczak, Wisley Chen, Shou-Chieh Hsu.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68082 )
Change subject: mb/google/nissa/var/yaviks: Config I2C frequency
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68082/comment/247a9eb7_05ebddf9
PS5, Line 11: I2C0: TPM: 997.7 Khz
: I2C1: Touchscreen: 392.6 Khz
: I2C3: Audio: 394.9 Khz
: I2C5: Touchpad: 391.6 Khz
nit: no need to duplicate these
File src/mainboard/google/brya/variants/yaviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68082/comment/bde877b2_650f3eff
PS5, Line 46: 55
I'd recommend increasing this to 56 to reduce the frequency a bit. This will help ensure it doesn't go over 1 MHz if the rise/fall times vary slightly between devices.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68082
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33c2891f17bc3c572bbfcbf30bbbdef9eb850ce7
Gerrit-Change-Number: 68082
Gerrit-PatchSet: 5
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Tue, 04 Oct 2022 02:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment