Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85838?usp=email )
Change subject: soc/mediatek/mt8196: Fix MT6363 buck5 enablement
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85838/comment/12926633_be1794f4?usp... :
PS1, Line 7: Correct MT6363 buck5 enable API
`Fix MT6363 buck5 enablement` (because the API (interface) isn't wrong)
Done
https://review.coreboot.org/c/coreboot/+/85838/comment/c2279a49_8b2db154?usp... :
PS1, Line 9: MT6363 buck5 is not used in rauru/navi. Fixed the incorrect mask and
: offset in the enable API.
Modify a few words: […]
Done
https://review.coreboot.org/c/coreboot/+/85838/comment/91db6fae_5cdff4a1?usp... :
PS1, Line 12: build pass
Please elaborate how you verify this patch.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85838?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0af1e0582ae8fc1e219f3cce536aed9985108be5
Gerrit-Change-Number: 85838
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 06 Jan 2025 13:22:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com