Attention is currently required from: Sean Rhodes, Matt DeVillier, Andy Pont, Stefan Reinauer.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61550 )
Change subject: payloads/tianocore: Rework Makefile
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/61550/comment/1a0a02bb_a9bb1af0
PS12, Line 89: rm -rf $(project_dir)
This seems a little dangerous to me. Maybe just bail out with an error here telling them to delete the directory and rebuild if they want to switch repos?
Alternatively, switch the directory name to correspond with which repo is being used so that it would just switch directories and download the other repo?
I know that some people actually develop in their payloads directories, and I don't want people to lose their data because of a slip up.
That could happen in a follow-on patch if you want.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61550
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic52e0afa7744f4a902274c41aed59ca23fd9f5fc
Gerrit-Change-Number: 61550
Gerrit-PatchSet: 12
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 03 Feb 2022 22:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment